tests: unittest: Added unittests for bm_nus #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can find the documentation preview for this PR here. |
marenges
force-pushed
the
ble_nus_unittests
branch
2 times, most recently
from
78523d0 to
643ac78
Compare
Added unit tests for subsys bm_nus Signed-off-by: Martin Engesvold <[email protected]>
marenges
force-pushed
the
ble_nus_unittests
branch
from
643ac78 to
860ab82
Compare
| TEST_ASSERT_EQUAL(BLE_GATTS_SRVC_TYPE_PRIMARY, type); | ||
| TEST_ASSERT_EQUAL(expected_uuid.type, p_uuid->type); | ||
| TEST_ASSERT_EQUAL(expected_uuid.uuid, p_uuid->uuid); | ||
| TEST_ASSERT_EQUAL(expected_conn_handle, *p_handle); |
There was a problem hiding this comment.
This should set the conn_handle afterwards. Then we can check that this is propagated later.
| struct ble_nus_client_context *last_link_ctx; | ||
|
|
||
| static uint32_t stub_sd_ble_gatts_service_add(uint8_t type, ble_uuid_t const *p_uuid, | ||
| uint16_t *p_handle, int calls) |
There was a problem hiding this comment.
Avoid hungarian notation (where we can, SoftDevice will still have it)
Suggested change
| uint16_t *p_handle, int calls) | |
| uint16_t *handle, int calls) |
| default: | ||
| return -1; | ||
| } | ||
|
|
| evt_handler_called = true; | ||
| } | ||
|
|
||
| static void init_nus(struct ble_nus_config *nus_cfg) |
There was a problem hiding this comment.
Suggested change
| static void init_nus(struct ble_nus_config *nus_cfg) | |
| static void nus_init(struct ble_nus_config *nus_cfg) |
| TEST_ASSERT_EQUAL_PTR(nus_cfg->evt_handler, ble_nus.evt_handler); | ||
| } | ||
|
|
||
| static void setup_with_notif_enabled(uint16_t conn_handle) |
There was a problem hiding this comment.
I think the ble_nus_on_ble_evt here should be kept as a as a separate call after init in the test. It makes it a lot easier to follow each test and see the difference.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added unit tests for subsys bm_nus